X Tutup
Skip to content

docs: fix first-app code getHousingLocationById housing.service.ts#67536

Merged
atscott merged 1 commit intoangular:mainfrom
nobilitat:patch-1
Mar 10, 2026
Merged

docs: fix first-app code getHousingLocationById housing.service.ts#67536
atscott merged 1 commit intoangular:mainfrom
nobilitat:patch-1

Conversation

@nobilitat
Copy link
Contributor

  1. Fixed url path ${this.url}/${id}
  2. Fixed method getHousingLocationById, now give in result correct location object.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

  1. {$this.url}/locations?id=${id} return empty array
  2. Method getHousingLocationById returned empty object: api return object type, locationJson[0] ?? {} - give in result empty object.

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

1. Get location by Id work with `${this.url}/${id}`
2. Method getHousingLocationById returned empty object, api return object type, locationJson[0] ?? {} - give in result empty object.
@google-cla

This comment was marked as outdated.

@pullapprove pullapprove bot requested a review from crisbeto March 10, 2026 05:18
@angular-robot angular-robot bot added the area: docs Related to the documentation label Mar 10, 2026
@ngbot ngbot bot added this to the Backlog milestone Mar 10, 2026
@JeanMeche JeanMeche removed the request for review from crisbeto March 10, 2026 09:30
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 10, 2026
@atscott atscott merged commit 9794e75 into angular:main Mar 10, 2026
22 checks passed
@atscott
Copy link
Contributor

atscott commented Mar 10, 2026

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup