refactor(core): declare explicit reactive node prototypes types#67510
Open
JoostK wants to merge 1 commit intoangular:mainfrom
Open
refactor(core): declare explicit reactive node prototypes types#67510JoostK wants to merge 1 commit intoangular:mainfrom
JoostK wants to merge 1 commit intoangular:mainfrom
Conversation
angular-robot
bot
added
area: core
These type annotations allow TS to associate the object's properties with their corresponding declaration in the interfaces, enabling much better code navigation. For example, "Find all implementations" for `ReactiveNode.producerRecomputeValue` now finds the implementation in `COMPUTED_NODE` and `LINKED_SIGNAL_NODE`.
JoostK
force-pushed
the
signals/flow-reactive-node-type
branch
from
f352552 to
9c18598
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These type annotations allow TS to associate the object's properties with their corresponding declaration in the interfaces, enabling much better code navigation. For example, "Find all implementations" for
ReactiveNode.producerRecomputeValuenow finds the implementation inCOMPUTED_NODEandLINKED_SIGNAL_NODE.