X Tutup
Skip to content

refactor(core): interface cleanup#67485

Merged
atscott merged 1 commit intoangular:mainfrom
JeanMeche:core-cleanup-interface
Mar 10, 2026
Merged

refactor(core): interface cleanup#67485
atscott merged 1 commit intoangular:mainfrom
JeanMeche:core-cleanup-interface

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Mar 5, 2026

Should be fine to land this time.

@JeanMeche
refactor(core): interface cleanup
57e9b03 
Should be fine to land this time.
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Mar 5, 2026
@ngbot ngbot bot added this to the Backlog milestone Mar 5, 2026
@JeanMeche JeanMeche marked this pull request as ready for review March 6, 2026 03:24
@JeanMeche
Copy link
Member Author

JeanMeche commented Mar 6, 2026 •
edited
Loading

presubmit is a flake, I ran a TGP just in case. This is good to go.

@JeanMeche JeanMeche requested a review from thePunderWoman March 6, 2026 13:57
thePunderWoman
thePunderWoman approved these changes Mar 6, 2026
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 6, 2026
@ngbot
Copy link

ngbot bot commented Mar 6, 2026

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@atscott atscott merged commit a675950 into angular:main Mar 10, 2026
23 of 25 checks passed
@atscott
Copy link
Contributor

atscott commented Mar 10, 2026

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@JeanMeche @atscott @thePunderWoman
X Tutup