PEP 828: Add tests#8
Merged
ZeroIntensity merged 4 commits intoZeroIntensity:async-yield-fromfrom Mar 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I left tests that are still mysteriously failing commented out.
Some of them probably don't make any sense and it's fine to remove them, but only some; most tests do apply to
async yield from.Return value tests are important because they currently hard crash the interpreter.
Also, I need to confirm whether objects we can pass to
async yield fromare correctly handled -- I feel that likely no and maybe we can raise better exceptions.I suggest the following workflow: for every test, try to uncomment and either:
Other approach would be to remove commented out tests, polish this PR minimally, merge this PR, keep a list of the missing tests elsewhere, and add them gradually.
Feel free to make a BDFL-ish decision on how we move forward from here.