fix(devtools): avoid direct import.meta access in rspack#349
Merged
AlemTuzlak merged 4 commits intoTanStack:mainfrom Mar 10, 2026
Merged
fix(devtools): avoid direct import.meta access in rspack#349AlemTuzlak merged 4 commits intoTanStack:mainfrom
AlemTuzlak merged 4 commits intoTanStack:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 65c525a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
This PR fixes Rspack compatibility issues by avoiding direct import.meta access patterns that trigger Rspack parser warnings. The changes move optional chaining from import.meta itself to its properties (e.g., import.meta?.env → import.meta.env?.), maintaining the same runtime behavior while satisfying Rspack's requirement for property-only access.
Changes:
- Replaced
import.meta?.envwithimport.meta.env?.in two locations to avoid direct import.meta access - Added a regression test that scans source files and fails on forbidden patterns:
import.meta?.,typeof import.meta, and= import.meta
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devtools/tests/import-meta-compat.test.ts | New test file that recursively scans src/ for forbidden import.meta patterns to prevent regressions |
| packages/devtools/src/core.tsx | Changed import.meta?.env?.SSR to import.meta.env?.SSR for Rspack compatibility |
| packages/devtools/src/components/source-inspector.tsx | Changed import.meta?.env?.BASE_URL to import.meta.env?.BASE_URL for Rspack compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlemTuzlak
approved these changes
Mar 10, 2026
Nsttt
force-pushed
the
fix/rspack-import-meta-property-access
branch
from
3730cba to
65c525a
Compare
|
View your CI Pipeline Execution ↗ for commit 65c525a
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/devtools
@tanstack/devtools-client
@tanstack/devtools-ui
@tanstack/devtools-utils
@tanstack/devtools-vite
@tanstack/devtools-event-bus
@tanstack/devtools-event-client
@tanstack/preact-devtools
@tanstack/react-devtools
@tanstack/solid-devtools
@tanstack/vue-devtools
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #348
import.meta?.envusages in devtools runtime code to property access (import.meta.env?.*)import.metaparser warning pathpackages/devtools/srcand fails on directimport.metaforms (import.meta?.,typeof import.meta,= import.meta)Why
Rspack warns on direct
import.metaaccess:Critical dependency: Accessing import.meta directly is unsupported (only property access or destructuring is supported)This change hardens devtools source against those patterns.
Validation
pnpm --filter @tanstack/devtools test:eslintpnpm --filter @tanstack/devtools test:libpnpm nx run @tanstack/devtools:buildpnpm --filter @tanstack/devtools test:typespnpm --filter @tanstack/devtools test:build