More accurate test dependencies by ShaharNaveh · Pull Request #7261 · RustPython/RustPython

ShaharNaveh · 2026-02-28T10:50:38Z

Standalone Tests

Untracked Files

site-packages/README.txt

Original Files

PSF-LICENSE
README.md
_dummy_os.py
_dummy_thread.py
_pycodecs.py
dummy_threading.py

Summary by CodeRabbit

New Features
- Extended test detection to recognize more naming patterns beyond conventional prefixes
- Improved library-to-test mapping for non-standard test module naming conventions
Refactoring
- Optimized internal utilities and updated type annotations for enhanced code clarity

coderabbitai · 2026-02-28T10:50:45Z

📝 Walkthrough

Walkthrough

This PR refactors test discovery and dependency resolution in the library update scripts. Changes include broadening test name matching patterns, updating type annotations to return frozensets, simplifying string manipulation using removeprefix/removesuffix, and expanding heuristics for deriving library names from test names.

Changes

Cohort / File(s)	Summary
Test Discovery Enhancement `scripts/update_lib/cmd_todo.py`	Broadened `get_all_tests` filtering to match any item containing "test" (not just prefix-based). Enhanced `compute_test_todo_list` suffix-stripping logic to handle additional patterns like "datetimetester" → "datetime" and "xmltests" → "xml" for improved test-to-library name mapping.
Dependency Resolution Refactoring `scripts/update_lib/deps.py`	Updated type annotations for `parse_test_imports` and `parse_lib_imports` to return `frozenset[str]`. Refactored helper functions using `removeprefix` and `removesuffix` for cleaner string manipulation. Simplified `ImportVisitor.lib_imports` to single-line expression. Minor reordering of codecs-related test dependency entries.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

ast.NodeVisitor for import tracking #7229: Modifies test-to-library name extraction logic in compute_test_todo_list with expanded suffix handling.
update_lib todo also shows test todo #6859: Changes test discovery utilities in get_all_tests and compute_test_todo_list with broadened test name pattern matching.
[update_lib] show deps #6821: Refactors dependency-resolution functions in deps.py including parse_test_imports and resolve_hard_dep_parent with string manipulation improvements.

Suggested labels

skip:ci

Suggested reviewers

moreal
youknowone

Poem

🐰 A bundle of tests now dances with grace,
With broader patterns they find their place,
Frozensets gleam, prefixes fade,
Dependencies mapped, the heuristics remade!
Scripts spring to life, cleaner and bright! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'More accurate test dependencies' directly describes the main changes in both modified files, which focus on improving test dependency tracking and extraction logic.
Docstring Coverage	✅ Passed	Docstring coverage is 81.82% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

scripts/update_lib/deps.py (1)
119-136: ⚠️ Potential issue | 🔴 Critical

frozenset return type breaks .discard() calls on result; causes AttributeError at runtime.

parse_lib_imports() and parse_test_imports() are annotated to return frozenset[str], but callers immediately call .discard() on the returned object (lines 1425, 1437). Since frozenset does not have a .discard() method, this raises AttributeError when parsing succeeds.

Additionally, the early-return statements (lines 132, 122) return set() instead of frozenset(), creating a type mismatch with the declared return type.

Fix: (1) Change early returns to frozenset(), (2) wrap parse_lib_imports() calls with set() at call sites that mutate the result:
imports = set(parse_lib_imports(content))
imports.discard(entry.stem)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@scripts/update_lib/deps.py` around lines 119 - 136, parse_lib_imports and
parse_test_imports are annotated to return frozenset but currently return
mutable set() on the early path and callers call .discard() on the result,
causing AttributeError; fix by making the functions consistently return
frozenset on the early-return path (replace set() with frozenset()) and do not
change the return type at the function level, and update call sites that need to
mutate the result (places that call .discard() on
parse_lib_imports/parse_test_imports results) to wrap the returned frozenset in
set(...) before mutating (e.g., imports = set(parse_lib_imports(content))); keep
references to ImportVisitor, parse_lib_imports, and parse_test_imports so you
can locate the code to change.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@scripts/update_lib/deps.py`:
- Around line 119-136: parse_lib_imports and parse_test_imports are annotated to
return frozenset but currently return mutable set() on the early path and
callers call .discard() on the result, causing AttributeError; fix by making the
functions consistently return frozenset on the early-return path (replace set()
with frozenset()) and do not change the return type at the function level, and
update call sites that need to mutate the result (places that call .discard() on
parse_lib_imports/parse_test_imports results) to wrap the returned frozenset in
set(...) before mutating (e.g., imports = set(parse_lib_imports(content))); keep
references to ImportVisitor, parse_lib_imports, and parse_test_imports so you
can locate the code to change.

ℹ️ Review info

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5c726e1 and 1e77e9f.

📒 Files selected for processing (2)

scripts/update_lib/cmd_todo.py
scripts/update_lib/deps.py

More accurate test dependencies

1e77e9f

ShaharNaveh marked this pull request as ready for review February 28, 2026 11:40

coderabbitai bot reviewed Feb 28, 2026

View reviewed changes

youknowone approved these changes Feb 28, 2026

View reviewed changes

youknowone merged commit f3cf86c into RustPython:main Feb 28, 2026
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More accurate test dependencies#7261

More accurate test dependencies#7261
youknowone merged 1 commit intoRustPython:mainfrom
ShaharNaveh:deps-more-accurate

ShaharNaveh commented Feb 28, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 28, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ShaharNaveh commented Feb 28, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Standalone Tests

Untracked Files

Original Files

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ShaharNaveh commented Feb 28, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 28, 2026 •

edited

Loading