Merged
Conversation
arihant2math
force-pushed
the
logging-312
branch
from
448da1c to
71a140d
Compare
Contributor
Author
|
All tests pass /cc @youknowone |
youknowone
requested changes
Jan 17, 2025
Member
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
Thank you so much! Everything in the code looks good.
Is this also from CPython 3.12.6? Leaving a specific import version on PR title is helpful to track the current RustPython library versions when we update it to next version.
Contributor
Author
|
Thanks, it's 3.12.7 this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out logging tests were not being tested, this pr adds them too. This also adds smtplib because that is needed for logging tests