Merged
Conversation
Member
c66dbcb to
cff6054
Compare
youknowone
approved these changes
Apr 16, 2024
Member
youknowone
left a comment
There was a problem hiding this comment.
Now everything looks working! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a PR for successful pip installation along with #5227, #5225 PR. Since
get-pip.pyneedsshutil.rmtree'sonexcparameter, I bumped the module to 3.12.3. And I checked that it can install pip and execute pip.But I'm not sure the
DirEntry.is_junctionimplementation is correct. I just used the code the below parts. It may need more research and confirmation.RustPython/vm/src/stdlib/os.rs
Lines 444 to 446 in b1c3c9a
Logs (pip installation & pip help)