Update test files from CPython v3.12.0#5127
Merged
youknowone merged 23 commits intoRustPython:mainfrom Nov 30, 2023
Merged
Conversation
ExpectedFailures added
Skip test at line 1861 ExpectedFailure at line 5104
ExpectedFailures at line 469-472 I'm not able to put a @unittest.expectedFailure for each tests so I commented them out
ExpectedFailure added at line 282
youknowone
approved these changes
Nov 30, 2023
Member
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
Thank you so much! Are you also interested in contribunting on Rust side? The newly introduced expectedFailures are usually a good source of good first issues to step on Rust side.
Contributor
Author
Kindly ask which issues are you referring to? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ticks plz #5104
There are no updates for the following test files so ticks for them too!
test_codeccallbacks
test_contains
test_deque
test_devpoll
test_dictcomps
test_docxmlrpc
test_dynamicclassattribute
test_errno
test_exception_hierarchy