BUG: Fix missing titles in roll parameter plots for fin sets#934
Merged
Gui-FernandesBR merged 3 commits intodevelopfrom Mar 8, 2026
Merged
BUG: Fix missing titles in roll parameter plots for fin sets#934Gui-FernandesBR merged 3 commits intodevelopfrom
Gui-FernandesBR merged 3 commits intodevelopfrom
Conversation
Call set_title(None) on clf_delta and cld_omega after set_inputs/set_outputs in Fins.evaluate_roll_parameters() so the title is auto-generated from the updated axis names instead of remaining None. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #934 +/- ##
===========================================
+ Coverage 80.27% 81.04% +0.76%
===========================================
Files 104 107 +3
Lines 12769 13888 +1119
===========================================
+ Hits 10250 11255 +1005
- Misses 2519 2633 +114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Fixes a plotting metadata regression in RocketPy fin-set roll parameter plots by ensuring Function.title is regenerated after updating axis labels.
Changes:
- Regenerate titles for
clf_deltaandcld_omegainFins.evaluate_roll_parameters()by callingset_title(None)afterset_inputs/set_outputs. - Remove an outdated TODO comment in fin roll plotting helper.
- Add a changelog entry documenting the bug fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
rocketpy/rocket/aero_surface/fins/fins.py |
Resets roll-parameter Function.title to auto-generate from updated input/output axis names. |
rocketpy/plots/aero_surface_plots.py |
Removes TODO comment now addressed by the fix. |
CHANGELOG.md |
Records the bug fix in the Unreleased “Fixed” section. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call set_title(None) on clf_delta and cld_omega after set_inputs/set_outputs in Fins.evaluate_roll_parameters() so the title is auto-generated from the updated axis names instead of remaining None.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Breaking change
Additional information
I'm testing claude code for the very first time