MNT: net thrust addition to 3 dof in flight class#907
Merged
Gui-FernandesBR merged 6 commits intodevelopfrom Dec 4, 2025
Merged
MNT: net thrust addition to 3 dof in flight class#907Gui-FernandesBR merged 6 commits intodevelopfrom
Gui-FernandesBR merged 6 commits intodevelopfrom
Conversation
- MNT: added net_thrust to u_dot_generalized_3dof in flight.py
There was a problem hiding this comment.
Pull request overview
This PR adds net_thrust to the 3 DOF flight simulation output, fixing an issue where plotting flight objects in 3 DOF mode would fail because the net_thrust property was not available.
Key changes:
- Added net_thrust calculation with pressure correction to
u_dot_generalized_3dofmethod - Updated post_processed_variables to include net_thrust (making it consistent with 6 DOF format)
- Added test to verify net_thrust and thrust_power properties are available in 3 DOF mode
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rocketpy/simulation/flight.py | Added net_thrust calculation with pressure correction and appended it to post_processed_variables in the 3 DOF simulation method to match 6 DOF format |
| tests/integration/simulation/test_flight_3dof.py | Added integration test to verify net_thrust property is available and thrust_power can be computed in 3 DOF mode |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #907 +/- ##
===========================================
+ Coverage 80.27% 81.03% +0.76%
===========================================
Files 104 107 +3
Lines 12769 13645 +876
===========================================
+ Hits 10250 11057 +807
- Misses 2519 2588 +69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aZira371
changed the title
aZira371
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
net_thrust is not a return of u_dot_generalized_3dof. This is causing errors in when flight object for 3 dof is plotted
New behavior
added net_thrust on the output of u_dot_generalized_3dof. This will allow to have consistent output format as 6 dof.
Breaking change
Additional information
Enter text here...