Enh/motor thrustcurve api by Marchma0 · Pull Request #870 · RocketPy-Team/RocketPy

Marchma0 · 2025-11-04T18:09:28Z

Pull request type

Code changes (bugfix, features)
Code maintenance (refactoring, formatting, tests)

Checklist

Tests for the changes have been added (if needed)
Lint (black rocketpy/ tests/) has passed locally
All tests (pytest tests -m slow --runslow) have passed locally

Current behavior

#661

New behavior

We added the function to load a motor from the thrustcruve API and we tested it.

Breaking change

No

…e test

Gui-FernandesBR · 2025-11-04T18:22:01Z

I really like this implementation!!

Copilot

Pull Request Overview

This PR adds a new method load_from_thrustcurve_api to the GenericMotor class that allows users to download motor data directly from the ThrustCurve.org API by providing a motor name. This feature simplifies motor initialization by eliminating the need to manually download .eng files.

Adds API integration with ThrustCurve.org to download motor data
Implements a new static method that searches for motors and downloads their .eng files
Includes comprehensive test coverage for the new functionality

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File	Description
rocketpy/motors/motor.py	Adds new static method `load_from_thrustcurve_api` with required imports (base64, tempfile, requests) to enable downloading and loading motor data from ThrustCurve API
tests/unit/motors/test_genericmotor.py	Adds test case to verify the new API loading functionality works correctly with Cesaroni M1670 motor data

rocketpy/motors/motor.py

Gui-FernandesBR · 2025-11-04T18:28:53Z

I see 2 major problems:

1 - Documentation: we should add a description of how to use the new feature.
2 - Tests: We should mock the API call so we don't exhaust the endpoint whenever we run the tests

…with clean imports

rocketpy/motors/motor.py

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.

rocketpy/motors/motor.py

tests/unit/motors/test_genericmotor.py

codecov · 2025-11-05T01:41:00Z

Codecov Report

❌ Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.33%. Comparing base (9cf3dd4) to head (f1cf70a).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines	Patch %	Lines
rocketpy/motors/motor.py	94.87%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #870      +/-   ##
===========================================
+ Coverage    80.27%   80.33%   +0.06%     
===========================================
  Files          104      104              
  Lines        12769    12815      +46     
===========================================
+ Hits         10250    10295      +45     
- Misses        2519     2520       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…urve_api with exception testing

Monta120 · 2025-11-05T07:42:08Z

@Gui-FernandesBR Thank you for going over the code. I just updated the latest commit to run make format for import/order/style cleanup and added tests for exception handling in load_from_thrustcurve_api.

…(as requested)

… genericmotors.rst file

Marchma0 · 2025-11-12T09:15:30Z

Hi all, We’ve updated the PR based on your feedback. Could you please check if it looks good now or if anything else needs improvement ?

Gui-FernandesBR · 2025-11-12T12:08:37Z

Hi all, We’ve updated the PR based on your feedback. Could you please check if it looks good now or if anything else needs improvement ?

@Marchma0 can you check why linters are not passing? Also, if you could please mark previous comments as "resolved", that would make our review easier

Marchma0 · 2025-11-13T17:04:01Z

We updated the code, i think we resolved pylint errors.

Marchma0 · 2025-11-17T09:59:34Z

Do you think there is something else to modify ? @Gui-FernandesBR

docs/user/motors/genericmotor.rst

rocketpy/motors/motor.py

Gui-FernandesBR

Needs changes.

Marchma0 · 2025-11-27T02:17:59Z

I sent you an invite to the fork. If its not working i will for sure add the requested changes for tomorow, thank you !!

…e test

…with clean imports

…urve_api with exception testing

…(as requested)

… genericmotors.rst file

Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ta-students/rocketpy into pr/Marchma0/870

Gui-FernandesBR

LGTM, hope it is working.

Great implementation!!

Add the function to create a motor from the API of thrustcurve and th…

05ab711

…e test

Marchma0 requested a review from a team as a code owner November 4, 2025 18:09

github-project-automation bot added this to LibDev Roadmap Nov 4, 2025

github-project-automation bot moved this to Backlog in LibDev Roadmap Nov 4, 2025

Gui-FernandesBR requested a review from Copilot November 4, 2025 18:20

Gui-FernandesBR changed the base branch from master to develop November 4, 2025 18:20

Copilot AI reviewed Nov 4, 2025

View reviewed changes

Monta120 force-pushed the enh/motor-thrustcurve-api branch from ff57272 to 2770ba2 Compare November 4, 2025 21:32

Improve load_from_thrustcurve_api and test_load_from_thrustcurve_api …

da39fcb

…with clean imports

Monta120 force-pushed the enh/motor-thrustcurve-api branch from 2770ba2 to da39fcb Compare November 4, 2025 21:57

Gui-FernandesBR reviewed Nov 5, 2025

View reviewed changes

rocketpy/motors/motor.py Show resolved Hide resolved

Gui-FernandesBR reviewed Nov 5, 2025

View reviewed changes

rocketpy/motors/motor.py Outdated Show resolved Hide resolved

Gui-FernandesBR requested review from Monta120, Copilot and phmbressan and removed request for Monta120 November 5, 2025 01:34

Copilot AI reviewed Nov 5, 2025

View reviewed changes

Clean up load_from_thrustcurve_api and improve test_load_from_thrustc…

9fdc704

…urve_api with exception testing

Monta120 added 2 commits November 5, 2025 12:43

Use warnings.warn() in load_from_thrustcurve_api when motor is found …

d123b47

…(as requested)

Added documentation for the load_from_thrustcurve_api method into the…

d6c5dee

… genericmotors.rst file

Changes to conform to lint

142eaf8

Marchma0 force-pushed the enh/motor-thrustcurve-api branch from 29a7aaa to 142eaf8 Compare November 17, 2025 14:56

Gui-FernandesBR reviewed Nov 27, 2025

View reviewed changes

docs/user/motors/genericmotor.rst Show resolved Hide resolved

Gui-FernandesBR reviewed Nov 27, 2025

View reviewed changes

rocketpy/motors/motor.py Outdated Show resolved Hide resolved

Gui-FernandesBR requested changes Nov 27, 2025

View reviewed changes

Marchma0 and others added 19 commits November 26, 2025 23:26

Add the function to create a motor from the API of thrustcurve and th…

22ea545

…e test

Improve load_from_thrustcurve_api and test_load_from_thrustcurve_api …

9315bd4

…with clean imports

Clean up load_from_thrustcurve_api and improve test_load_from_thrustc…

df3335a

…urve_api with exception testing

Use warnings.warn() in load_from_thrustcurve_api when motor is found …

eb47e31

…(as requested)

Added documentation for the load_from_thrustcurve_api method into the…

505a9fa

… genericmotors.rst file

Changes to conform to lint

9ac9bcc

Fixed Pylint errors

c4bf266

Update docs/user/motors/genericmotor.rst

94fa35e

Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>

Update docs/user/motors/genericmotor.rst

d50c03f

Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>

Update docs/user/motors/genericmotor.rst

d3f0997

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Set private the method call_thrustcurve_api

ea1ed6e

Update docs/user/motors/genericmotor.rst

eda5e5a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tests/unit/motors/test_genericmotor.py

15f12c4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update rocketpy/motors/motor.py

ddbc22d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update docs/user/motors/genericmotor.rst

18a0fcb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update docs/user/motors/genericmotor.rst

fb8db26

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update docs/user/motors/genericmotor.rst

0d6fb34

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Modify the changelog

3d53911

Bug fix

a048bb4

Gui-FernandesBR force-pushed the enh/motor-thrustcurve-api branch from be79157 to a048bb4 Compare November 27, 2025 02:26

Merge branch 'enh/motor-thrustcurve-api' of https://github.com/idl-im…

f1cf70a

…ta-students/rocketpy into pr/Marchma0/870

Gui-FernandesBR approved these changes Nov 27, 2025

View reviewed changes

github-project-automation bot moved this from Backlog to Next Version in LibDev Roadmap Nov 27, 2025

Gui-FernandesBR merged commit 157042d into RocketPy-Team:develop Nov 27, 2025
7 checks passed

github-project-automation bot moved this from Next Version to Closed in LibDev Roadmap Nov 27, 2025

Gui-FernandesBR linked an issue Nov 27, 2025 that may be closed by this pull request

ENH: Integrate with thrust.org API to retrieve data from their server #661

Closed

Uh oh!

Conversation

Marchma0 commented Nov 4, 2025

Pull request type

Checklist

Current behavior

New behavior

Breaking change

Uh oh!

Gui-FernandesBR commented Nov 4, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Gui-FernandesBR commented Nov 4, 2025

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Monta120 commented Nov 5, 2025

Uh oh!

Marchma0 commented Nov 12, 2025

Uh oh!

Gui-FernandesBR commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Marchma0 commented Nov 13, 2025

Uh oh!

Marchma0 commented Nov 17, 2025

Uh oh!

Uh oh!

Uh oh!

Gui-FernandesBR left a comment

Choose a reason for hiding this comment

Uh oh!

Marchma0 commented Nov 27, 2025

Uh oh!

Gui-FernandesBR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Nov 5, 2025 •

edited

Loading

Gui-FernandesBR commented Nov 12, 2025 •

edited

Loading