Pull Request Overview

This PR refactors the Flight class's __simulate() method to improve readability and enable time overshoot functionality for controllers and sensors. The main changes include:

• Breaking down the monolithic __simulate() method into smaller, focused methods for better maintainability
• Enabling controllers and sensors to work with time_overshoot=True option, which was previously disabled
• Optimizing simulation performance by allowing overshootable time nodes for sensors and controllers

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Good work! I hope this is the beginning of having a much more readable and developer friendly Flight class.

My only concern is making sure the behavior is exactly the same as before, therefore I made a single important comment on the early return of parachute triggers just to make sure we are on the same page. Of course, all the tests being green is already a big step.

Aside from that, my other suggestions are more style/naming choices. I prefer having some more standardized names for some methods, but I would approve the PR in the current state even if these suggestions are not taken, since it already does loads for readability.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

                self.__process_sensors_and_controllers_at_current_node(node, phase)

                for controller in node._controllers:
                    controller(
                        self.t,
                        self.y_sol,
                        self.solution,
                        self.sensors,
                    )

                for parachute in node.parachutes:
                    # Calculate and save pressure signal
                    (
                        noisy_pressure,
                        height_above_ground_level,
                    ) = self.__calculate_and_save_pressure_signals(
                        parachute, node.t, self.y_sol[2]
                    )
                    if parachute.triggerfunc(
                        noisy_pressure,
                        height_above_ground_level,
                        self.y_sol,
                        self.sensors,
                    ):
                        # Remove parachute from flight parachutes
                        self.parachutes.remove(parachute)