BUG: Time Node Merge Not Including Controllers#647
Merged
Gui-FernandesBR merged 3 commits intodevelopfrom Aug 3, 2024
Merged
Conversation
Gui-FernandesBR
approved these changes
Jul 30, 2024
phmbressan
approved these changes
Jul 30, 2024
Member
You can easily create a test simulating a rocket with parachute and air brakes, checking if both work. Just like the bug report. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #647 +/- ##
===========================================
+ Coverage 75.71% 75.74% +0.03%
===========================================
Files 81 81
Lines 9815 9821 +6
===========================================
+ Hits 7431 7439 +8
+ Misses 2384 2382 -2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
CHANGELOG.mdhas been updated (if relevant)Description
Found by team RED on Discord.
Controller time nodes were being ignored and discarded in the merging of the time nodes, now they are correctly considered