ENH: CP and Thrust Eccentricity Effects Generate Roll Moment#617
ENH: CP and Thrust Eccentricity Effects Generate Roll Moment#617Gui-FernandesBR merged 7 commits intodevelopfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #617 +/- ##
===========================================
- Coverage 73.60% 73.60% -0.01%
===========================================
Files 70 70
Lines 10290 10292 +2
===========================================
+ Hits 7574 7575 +1
- Misses 2716 2717 +1 ☔ View full report in Codecov by Sentry. |
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Send like r1 and r2 are aligned to the global coordinate system (the earth) but the x and y excentricity should be aligned to the local (rocket) coordinate system.
Right now I understand you are assuming R1 is always parallel to x_excentricity, right?
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Please update the CHANGELOG
R1, R2, and R3 are described in the rocket coordinate system from what I understand What I did here is in accordance with what the code was doing before, I am not assuming anything different. But yes, I believe the R1 was assumed to be parallel to x |
2 participants
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
CP eccentricities did not generate moment on the rocket's center axis (roll moment M3) and thrust eccentricity was not included in
u_dot_generalizedNew behavior
Roll moment is calculated properly and thrust eccentricity is included in
u_dot_generalizedBreaking change