BUG: pyproject.toml Main Module Finding.#616
Merged
phmbressan merged 2 commits intomasterfrom Jun 3, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #616 +/- ##
==========================================
+ Coverage 73.60% 73.65% +0.04%
==========================================
Files 70 70
Lines 10289 10289
==========================================
+ Hits 7573 7578 +5
+ Misses 2716 2711 -5 ☔ View full report in Codecov by Sentry. |
Gui-FernandesBR
force-pushed
the
rel/v1.3.0.post1
branch
from
cb67354 to
cd14018
Compare
Gui-FernandesBR
approved these changes
Jun 2, 2024
Member
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Tested on Python 3.10.11 running on windows 11 and it worked quite well.
python -m venv .venv
pip install -e .[all]
pip install -r requirements-tests.txt
pytest
MateusStano
approved these changes
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
CHANGELOG.mdhas been updated (if relevant)Current behavior
There is an issue with package discovery in current build with
pyproject.toml.New behavior
This PR allows for the discovery of
rocketpymain package and its submodules.Breaking change