BUG: plot drag curves when function source is callable#599
Merged
Gui-FernandesBR merged 3 commits intodevelopfrom May 16, 2024
Merged
BUG: plot drag curves when function source is callable#599Gui-FernandesBR merged 3 commits intodevelopfrom
Gui-FernandesBR merged 3 commits intodevelopfrom
Conversation
Gui-FernandesBR
added
Bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #599 +/- ##
===========================================
- Coverage 73.37% 73.35% -0.02%
===========================================
Files 57 57
Lines 9453 9473 +20
===========================================
+ Hits 6936 6949 +13
- Misses 2517 2524 +7 ☔ View full report in Codecov by Sentry. |
phmbressan
reviewed
May 16, 2024
MateusStano
reviewed
May 16, 2024
Member
MateusStano
left a comment
MateusStano
left a comment
There was a problem hiding this comment.
Could you also fix this line?
The airfoil prints will run into the same bug if it is callable defined
Member
Author
This is a very good comment. Let's fix it in another PR. I think it's important to add a test to this PR so we prevent the same error from happening again in the future |
phmbressan
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
When you use a callable object as the source of your power_on or power_off curves in the Rocket class, the
all_info()method will break becauseself.rocket.power_on_drag.x_arrayis inexistentNew behavior
Solved the issue by adding a try/except block that will prevent code from breaking in the situation
Breaking change
Additional information
None