FIX: Optional Dependencies Naming in pyproject.toml.#592
Merged
phmbressan merged 2 commits intodevelopfrom May 2, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #592 +/- ##
===========================================
+ Coverage 72.97% 73.03% +0.05%
===========================================
Files 57 57
Lines 9596 9596
===========================================
+ Hits 7003 7008 +5
+ Misses 2593 2588 -5 ☔ View full report in Codecov by Sentry. |
MateusStano
approved these changes
May 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
CHANGELOG.mdhas been updated (if relevant)Current behavior
The installation of optional dependencies
env-analysisandàllis not working as expected, yielding the following results:env-analysis install results
The same happens with `env_analysis`.
"all" install result
New behavior
Changing the naming of
env_anaysisto the python package normalizedenv-analysisfixes the first installation issue.The second was the addition of the
allto the optional dependencies.Breaking change
Additional information
The recursive syntax to generate the
allin thepyproject.tomlfile is only supported frompip>=21.2(from 2021). The+symbol fromsetup.pyis not valid inpyproject.toml.If this is understood as a too strict version compromise, listing all the dependencies is the alternative.