DOC: Convert CompareFlights example notebooks to .rst files#576
Merged
Gui-FernandesBR merged 4 commits intodevelopfrom Mar 18, 2024
Merged
DOC: Convert CompareFlights example notebooks to .rst files#576Gui-FernandesBR merged 4 commits intodevelopfrom
Gui-FernandesBR merged 4 commits intodevelopfrom
Conversation
Member
Author
MateusStano
reviewed
Mar 18, 2024
MateusStano
reviewed
Mar 18, 2024
MateusStano
reviewed
Mar 18, 2024
MateusStano
approved these changes
Mar 18, 2024
Member
MateusStano
left a comment
There was a problem hiding this comment.
LGTM! I've built the docs on readthedocs and everything seems to be fine.
I left a few suggestions but they are not a big deal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
The example notebooks are not executed when building the documentation.
There's no way to add custom widgets (i.e. "seealso", "important", etc.)
New behavior
Two .ipynb files were converted to .rst files.
Sphinx will now execute the code cells whenever we build the docs.
Breaking change
Additional information