Merged
Conversation
github-actions
bot
requested review from
MateusStano,
giovaniceotto and
phmbressan
Gui-FernandesBR
commented
Feb 8, 2024
| ### Fixed | ||
|
|
||
|
|
||
| ## [v1.2.0] - 2024-02-dd |
Member
Author
There was a problem hiding this comment.
The dd will be replaced with the release day in a future PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #550 +/- ##
========================================
Coverage 72.45% 72.46%
========================================
Files 59 59
Lines 9569 9568 -1
========================================
Hits 6933 6933
+ Misses 2636 2635 -1 ☔ View full report in Codecov by Sentry. |
phmbressan
approved these changes
Feb 9, 2024
Collaborator
phmbressan
left a comment
phmbressan
left a comment
There was a problem hiding this comment.
Good fixes, I agree with the changes. Elevated the overall organization of the repository, specially regarding the CHANGELOG.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
Some comments point out at #536
New behavior
See the commit history, one by one, so you can have an idea of what was changed.
Breaking change
Additional information
Rather opening this PR than committing directly to the develop branch, hope you don't mind.