ENH: Function inputs from CSV file header.#542
Merged
phmbressan merged 6 commits intodevelopfrom Feb 7, 2024
Merged
Conversation
github-actions
bot
requested review from
Gui-FernandesBR,
MateusStano and
giovaniceotto
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #542 +/- ##
===========================================
+ Coverage 72.32% 72.35% +0.02%
===========================================
Files 56 56
Lines 9399 9407 +8
===========================================
+ Hits 6798 6806 +8
Misses 2601 2601 ☔ View full report in Codecov by Sentry. |
MateusStano
reviewed
Jan 31, 2024
Gui-FernandesBR
approved these changes
Feb 5, 2024
Member
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Good job. i confirm it's working as expected.
Gui-FernandesBR
approved these changes
Feb 5, 2024
Member
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Good job. i confirm it's working as expected.
Gui-FernandesBR
added
the
Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
The Function class did not get the inputs and outputs name from the header of CSV file.
New behavior
If the CSV file has headers, the input and output parameters that are left
Nonewill be set from the header information.Breaking change