DOC: Installing imageio library on dispersion analysis notebook#540
DOC: Installing imageio library on dispersion analysis notebook#540phmbressan merged 1 commit intodevelopfrom
Conversation
github-actions
bot
requested review from
Gui-FernandesBR,
MateusStano and
phmbressan
Lucas-Prates
added
Docs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #540 +/- ##
========================================
Coverage 72.34% 72.34%
========================================
Files 56 56
Lines 9393 9393
========================================
Hits 6795 6795
Misses 2598 2598 ☔ View full report in Codecov by Sentry. |
|
In order to test it on colab: https://colab.research.google.com/github/RocketPy-Team/rocketpy/blob/master/docs/notebooks/dispersion_analysis/dispersion_analysis.ipynb This link clones from master branch, so we need to modify the pip install command before running all the cells. |
|
The code is running as expected here. In the future we might wanna change the implementation to fix this warning: |
There was a problem hiding this comment.
Works on colab lol
Thanks a lot and congratulations for your first contribution, @Lucas-Prates !!!
Let's wait until our meeting so we let other people see the PR before merging :)
3 participants
Pull request type
Checklist
Current behavior
The dispersion analysis notebook uses, on its last cell, the library imageio, but does not install it at any point, nor is it a dependency. Executing the whole notebook without having the library prompts a "ModuleNotFoundError" at the last cell.
New behavior
Install imageio at the 'Install and Load Libraries' section.
Breaking change
Additional information
The installation is done exclusively for this notebook, so there are no changes to dependencies.