ENH: improve Function.low_pass_filter and adds docs#538
Merged
Gui-FernandesBR merged 1 commit intodevelopfrom Jan 23, 2024
Merged
ENH: improve Function.low_pass_filter and adds docs#538Gui-FernandesBR merged 1 commit intodevelopfrom
Gui-FernandesBR merged 1 commit intodevelopfrom
Conversation
- Persist the inputs, outputs and title of the original Function - Improve the method docstring - Add an example to the .rst file
github-actions
bot
requested review from
MateusStano,
giovaniceotto and
phmbressan
Gui-FernandesBR
added
Enhancement
Gui-FernandesBR
changed the title
Member
Author
|
This is how the new docs look like:
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #538 +/- ##
===========================================
+ Coverage 72.32% 72.33% +0.01%
===========================================
Files 56 56
Lines 9389 9389
===========================================
+ Hits 6791 6792 +1
+ Misses 2598 2597 -1 ☔ View full report in Codecov by Sentry. |
phmbressan
approved these changes
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
While using the new low_pass_filter method, I noticed some minor adjustments could be done, let's see:
New behavior
Breaking change