MNT: Encapsulate quaternion conversions#537
Conversation
github-actions
bot
requested review from
MateusStano,
giovaniceotto and
phmbressan
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #537 +/- ##
===========================================
+ Coverage 72.32% 72.34% +0.01%
===========================================
Files 56 56
Lines 9389 9393 +4
===========================================
+ Hits 6791 6795 +4
Misses 2598 2598 ☔ View full report in Codecov by Sentry. |
phmbressan
left a comment
phmbressan
left a comment
There was a problem hiding this comment.
The documentation helps, but I have a minor issue with the naming schema of the created functions.
You certainly have more experience on quaternions than I, so I would like to hear your opinion:
-
Except the
precessionone, the names end up with the angle naming convention used for RocketPy (phi,theta). -
I know this is a common angle convention, but I am not sure of it is universal. So I believe it would be better to name them after their "physical angle", such as
precessionandnutation.
You have a good point. Can you please re-review it? |
3 participants
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
We take quaternions (euler parameters) and calculate euler angles inside the flight class, but this code cannot be reused in other applications.
New behavior
Breaking change
Additional information
This is going to be quite useful for the
rocketpy.simulation.FlightDataImporterclass.