Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (223d598) 71.15% compared to head (a3e49a2) 71.23%.
Report is 1 commits behind head on master.

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
+ Coverage   71.15%   71.23%   +0.08%     
==========================================
  Files          55       55              
  Lines        9259     9259              
==========================================
+ Hits         6588     6596       +8     
+ Misses       2671     2663       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Should we expect any significant increase in simulation execution speed since we are adding a new call inside Flight.__init__?

Should we expect any significant increase in simulation execution speed since we are adding a new call inside Flight.__init__?

That could be tested, of course, but I don't think so. The method basically makes two Function instances per parachute if I recall correctly.

Unless the simulation has unusualy too many points or a lot of parachutes, the time spend should be in the ms range.

Again, that could be easily tested later. This solution is not the best one, but I do think it involves the least amount of changes for a Hotfix.

I am open to other suggestions.

Should we expect any significant increase in simulation execution speed since we are adding a new call inside Flight.__init__?

That could be tested, of course, but I don't think so. The method basically makes two Function instances per parachute if I recall correctly.

Unless the simulation has unusualy too many points or a lot of parachutes, the time spend should be in the ms range.

Again, that could be easily tested later. This solution is not the best one, but I do think it involves the least amount of changes for a Hotfix.

I am open to other suggestions.

I reviewed it again and I don't think it's a problem. The new behavior is not prejudicial in terms of code performance.

In order to prevent future errors, we ideally should implement unit test for the methods we fix in hotfixes.
I did that in my last commit a3e49a2.

@phmbressan please review the commit and feel free to proceed and merge.

In order to prevent future errors, we ideally should implement unit test for the methods we fix in hotfixes.
I did that in my last commit a3e49a2.

@phmbressan please review the commit and feel free to proceed and merge.

Since I opened the PR GitHub does not allow me to submit an approval.