BUG: Invalid Arguments on Two Dimensional Discretize (HOTFIX).#521
Merged
Gui-FernandesBR merged 5 commits intomasterfrom Jan 18, 2024
Merged
BUG: Invalid Arguments on Two Dimensional Discretize (HOTFIX).#521Gui-FernandesBR merged 5 commits intomasterfrom
Gui-FernandesBR merged 5 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #521 +/- ##
==========================================
+ Coverage 70.92% 71.15% +0.22%
==========================================
Files 55 55
Lines 9262 9259 -3
==========================================
+ Hits 6569 6588 +19
+ Misses 2693 2671 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Gui-FernandesBR
previously approved these changes
Jan 12, 2024
Member
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Very well solved, thank you.
MateusStano
previously approved these changes
Jan 17, 2024
phmbressan
commented
Jan 17, 2024
phmbressan
dismissed stale reviews from MateusStano and Gui-FernandesBR
via
223d598
Gui-FernandesBR
approved these changes
Jan 17, 2024
MateusStano
approved these changes
Jan 17, 2024
lucasfourier
approved these changes
Jan 18, 2024
MateusStano
approved these changes
Jan 18, 2024
Gui-FernandesBR
requested review from
Gui-FernandesBR,
MateusStano and
lucasfourier
Gui-FernandesBR
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
The PR #451 introduced a standard for the
get_valuearguments regarding multidimensional Functions that were not updated everywhere in code: the methodset_discretefor 2D Functions breaks. One may verify it by running onmaster:New behavior
During debug there were two root causes for the error that were fixed:
get_valuecall still used one argument for two dimensional domains: a simple argument separation was enough for a fix.__check_user_inputsmethod did not account for the possibility of aFunctionbeing a source.Basic tests were implemented. Since this is a hotfix, I avoided changing much, but a full fix involves exploring issue #481 and improving the sets for interpolation and extrapolation that are quite circular in current code.
More tests and better docs for discretize are incoming on #519 .
Breaking change
Other Information
The original motivation that lead to this bug discovery was from codecov, who told be in PR #519 that the tests did not cover 2D
Function.