ENH: Argument for Optional Mutation on Function Discretize#519
Merged
Gui-FernandesBR merged 12 commits intodevelopfrom Jan 20, 2024
Merged
ENH: Argument for Optional Mutation on Function Discretize#519Gui-FernandesBR merged 12 commits intodevelopfrom
Gui-FernandesBR merged 12 commits intodevelopfrom
Conversation
phmbressan
added
the
Enhancement
github-actions
bot
requested review from
Gui-FernandesBR,
MateusStano and
giovaniceotto
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #519 +/- ##
===========================================
+ Coverage 71.99% 72.20% +0.20%
===========================================
Files 56 56
Lines 9374 9376 +2
===========================================
+ Hits 6749 6770 +21
+ Misses 2625 2606 -19 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
I will work on the codecov report later. |
7 tasks
Gui-FernandesBR
approved these changes
Dec 22, 2023
Member
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Well done, I don't see any breaking changes happening here.
It would be nice to include tests for 2-D functions.
7 tasks
Member
|
@phmbressan do you know what is happening with the GitHub actions here? |
Collaborator
Author
There was one test that oddly failed on first pass forcing the others to be run manually. |
Gui-FernandesBR
force-pushed
the
enh/optional-discretize-mutation
branch
from
a445f6e to
9b20258
Compare
…' into enh/optional-discretize-mutation
Gui-FernandesBR
approved these changes
Jan 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
The behavior of
Function.set_discreteis well documented, but not exactly intuitive: the originalFunctionis always mutated. This may not always be the need of the user and it has caused problems before in development, such as #514 .New behavior
This PR adds a new optional parameter (whose default does not call a breaking change) so that it may be specified whether the
selfshould be discretized.Tests for the changes have been added.
Breaking change
Additional information
Please, on review make a sanity recheck that this is not a breaking change.