BUG: EmptyMotor is breaking the Rocket.draw() method#516
Merged
Gui-FernandesBR merged 2 commits intodevelopfrom Dec 19, 2023
Merged
BUG: EmptyMotor is breaking the Rocket.draw() method#516Gui-FernandesBR merged 2 commits intodevelopfrom
Gui-FernandesBR merged 2 commits intodevelopfrom
Conversation
github-actions
bot
requested review from
MateusStano,
giovaniceotto and
phmbressan
Gui-FernandesBR
force-pushed
the
bug/empty-motor-draw
branch
from
eafed86 to
f1367e3
Compare
Gui-FernandesBR
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #516 +/- ##
===========================================
+ Coverage 71.16% 71.30% +0.14%
===========================================
Files 55 56 +1
Lines 9279 9374 +95
===========================================
+ Hits 6603 6684 +81
- Misses 2676 2690 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
phmbressan
approved these changes
Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
Try to call the Rocket.draw() method without adding a motor to the rocket. The EmptyMotor will be used as default, the plot will be created but an error will also be displayed
New behavior
Changed the order of some operations and solved the problem.
Breaking change
Additional information
Bug reported from UPV-Faraday rocketry team (Valencia, Spain).