ENH: Shepard Optimized Interpolation - Multiple Inputs Support#515
ENH: Shepard Optimized Interpolation - Multiple Inputs Support#515phmbressan merged 11 commits intodevelopfrom
Conversation
- Minor bug in computation if distance zero solved
phmbressan
added
the
Enhancement
github-actions
bot
requested review from
Gui-FernandesBR,
MateusStano and
giovaniceotto
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #515 +/- ##
===========================================
- Coverage 72.36% 72.16% -0.21%
===========================================
Files 56 56
Lines 9409 9362 -47
===========================================
- Hits 6809 6756 -53
- Misses 2600 2606 +6 ☔ View full report in Codecov by Sentry. |
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Nice job here. Thanks for the contribution.
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
There was a conflict on the changelog, I solved it and now I'm re-approaving.
Excellent PR, this really demonstrantes how Brillant are some people in our team.
In this case, @phmbressan .
ps.: Thank you numpy for existing.
2 participants
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
The optimized method
get_value_optforshepardinterpolation had a great speed up by #501. However, this method did not support (even before than the #501) arrays of inputs.New behavior
Inspired by the implementation made in the aforementioned PR, the support for multiple inputs was added in the optimized way, benefiting from the great speed up implemented. Since this also satisfies the requisites for the common
get_valuemethod while being faster, it was also updated.Breaking change