DOC: Change from % to ! in the first cell to run properly in Colab.#496
Merged
MateusStano merged 2 commits intorel/v1.1.4from Dec 7, 2023
Merged
Conversation
github-actions
bot
requested review from
Gui-FernandesBR,
MateusStano and
phmbressan
Member
|
Could we no longer use a git clone command in this notebook? We are currently downloading more than 1.7 GB of data just to use a drag curve and a thrust curve. It's completely unnecessary. I would suggest we should download only the two files we need. This would speed up our getting started example by a lot. |
Member
|
The following notebooks also suffer from the same problem:
Should we also update them? |
MateusStano
approved these changes
Dec 6, 2023
Merged
Gui-FernandesBR
deleted the
doc/fix-getting-started-colab-notebook-error
branch
Member
|
The
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
Current behavior
The first code cell of our Google Colab Getting Started Notebook fails because it is using
%instead of!to execute shell commands.New behavior
%was replaced by!andnetCDFwas removed frompip installsince it is already installed when RocketPy is installed now.Breaking change
Additional information
This does not affect the RocketPy package in PyPI, so a new release is not necessary. As it affects only an example referenced in the ReadMe, I suggest merging it directly to master soon.
You can run the new fixed notebook here: https://colab.research.google.com/github/RocketPy-Team/rocketpy/blob/doc/fix-getting-started-colab-notebook-error/docs/notebooks/getting_started_colab.ipynb