BUG: Function breaks if a header is present in the csv file#485
BUG: Function breaks if a header is present in the csv file#485phmbressan merged 10 commits intomasterfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #485 +/- ##
==========================================
+ Coverage 70.89% 70.91% +0.02%
==========================================
Files 55 55
Lines 9258 9261 +3
==========================================
+ Hits 6563 6567 +4
+ Misses 2695 2694 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- single line headers are now officially supported... - with or without quotes. - The docstring was updated.
Gui-FernandesBR
changed the title
There was a problem hiding this comment.
LGTM!
All tests are passing locally, including with the --run-slow option
The check_user_inputs method is raising more problems than what I thought in the beginning. Improvements for this method are welcome, and I believe there's already an issue for that.
Good news: docs are passing! See https://docs.rocketpy.org/en/bug-v1.1.1-docs-build/
Co-authored-by: Giovani Hidalgo Ceotto <ghceotto@gmail.com>
Co-authored-by: Giovani Hidalgo Ceotto <ghceotto@gmail.com>
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
This Looks Good To Me
4 participants
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
The
Function.__check_user_inputsdid not support headered csv, which caused an error on docs build.New behavior
The support for headered csv was added and there was a
LiquidMotorexample in the docs that needed refactor to the new cap height definition.Breaking change