HOTFIX: Negative Static Margin#476
Conversation
github-actions
bot
requested review from
Gui-FernandesBR,
MateusStano and
phmbressan
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #476 +/- ##
==========================================
- Coverage 70.80% 70.70% -0.10%
==========================================
Files 55 55
Lines 9234 9234
==========================================
- Hits 6538 6529 -9
- Misses 2696 2705 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
This Looks Good To Me
|
@giovaniceotto I think u can merge this one already. Could u create release notes pls? |
I will let the boss @MateusStano do it in case there is anything else relevant that I am not aware of.
I wanted to create it in the file, but it isn't in master yet. So I'll just do it here to help the release: Fixed
|
4 participants
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCurrent behavior
When using the
nose_to_tailcoordinate system for theRocketclass, the sign of the static margin was inverted since a sign correction was applied twice, as noticed by @MateusStano.New behavior
Things just work now. One of the sign corrections was removed. Ironically, we had tests for this, but they were not working properly. This has also been fixed.
Version has been bumped up to v1.1.1 so that a hotfix can be released.
Breaking change
Additional information
This bug was reported by Bob Brown [D&W] (MΦNK3Y#2638) through our Discord server.