BUG: Fix find_input() Function to Return a Single Value#471
Merged
Gui-FernandesBR merged 1 commit intodevelopfrom Nov 19, 2023
Merged
BUG: Fix find_input() Function to Return a Single Value#471Gui-FernandesBR merged 1 commit intodevelopfrom
Gui-FernandesBR merged 1 commit intodevelopfrom
Conversation
MateusStano
requested review from
Gui-FernandesBR
and removed request for
giovaniceotto
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #471 +/- ##
========================================
Coverage 70.86% 70.86%
========================================
Files 55 55
Lines 9227 9227
========================================
Hits 6539 6539
Misses 2688 2688
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Gui-FernandesBR
approved these changes
Nov 19, 2023
Member
|
It passes on my |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyNew behavior
Scipy's
optimize.rootgives an array of length 1 to the Function object insidefind_input. Currently if a Function receives an Iterable, it returns a list. This was not always the case before #451.Now
find_inputshould always work, independent of the Function source