X Tutup
Skip to content

DOC: first simulation allinfo#466

Merged
Gui-FernandesBR merged 6 commits intodevelopfrom
docs/first-simulation-allinfo
Nov 19, 2023
Merged

DOC: first simulation allinfo#466
Gui-FernandesBR merged 6 commits intodevelopfrom
docs/first-simulation-allinfo

Conversation

@FranzYuri
Copy link
Contributor

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates
  • Other (please describe):

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest --runslow) have passed locally

Current behavior

The first simulation page runs the all_info method, something that can be overwhealming for a new user

New behavior

Now, instead of calling the all_info method methods for each plot are called, alongside a brief description of each of them

Breaking change

  • Yes
  • No

Additional information

Enter text here...

@Gui-FernandesBR Gui-FernandesBR changed the base branch from master to develop November 18, 2023 18:49
@Gui-FernandesBR Gui-FernandesBR changed the title Docs/first simulation allinfo DOC: first simulation allinfo Nov 18, 2023
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thank you very much @FranzYuri !! I've made some improvements based on your PR, thank you very much.

@Gui-FernandesBR Gui-FernandesBR merged commit 14937a7 into develop Nov 19, 2023
@Gui-FernandesBR Gui-FernandesBR deleted the docs/first-simulation-allinfo branch November 19, 2023 01:59
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Nov 20, 2023
@Gui-FernandesBR Gui-FernandesBR restored the docs/first-simulation-allinfo branch November 20, 2023 02:26
@Gui-FernandesBR Gui-FernandesBR deleted the docs/first-simulation-allinfo branch November 20, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Closed

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup