ENH: Clean Plots and Prints Subpackages init files#457
Merged
MateusStano merged 1 commit intodevelopfrom Nov 13, 2023
Merged
Conversation
Gui-FernandesBR
approved these changes
Nov 9, 2023
Member
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Well done!
The plots and prints modules are more consistent now.
phmbressan
approved these changes
Nov 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCurrent behavior
Because of some circular imports errors, the
__init__.pyfile of theplotssubpackage was changed to be empty. This is not an issue because the plots classes are only meant to be imported in other files of the library. However, theCompareFlightsclass is in this subpackage, and it is meant to be easily imported.New behavior
The
printssubpackage__init.py__file is also empty and the imports for the Compare classes have been addedBreaking change
Additional information
Just to make things clear. Currently, in
masterwe can do:or
and for compare we had to do
With the changes of this PR, we can do only
and for compare we now can do
or