DOC: fix positions and coordinate system documentation page#454
Merged
MateusStano merged 4 commits intodevelopfrom Nov 7, 2023
Merged
DOC: fix positions and coordinate system documentation page#454MateusStano merged 4 commits intodevelopfrom
MateusStano merged 4 commits intodevelopfrom
Conversation
Member
MateusStano
approved these changes
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
Current behavior
The
Positions and Coordinate Systemsdocumentation page is an amazing resource that explains what is perhaps the most misunderstood part of RocketPy! However, even the greatest of resources can still be improved a bit.Here are a couple of mistakes I found while reviewing it when working on another PR:
Positions and Coordinate Systemsdocumentation page was actually just a copy of the section above.+and-signs reversed.nozzletcomb.pngwas not used and likely the result of a typo.New behavior
Breaking change
Additional information
The reviewer may chose to review commit by commit in order to better understand the changes made.
RTD preview link: https://docs.rocketpy.org/en/doc-fix-positions-documentation/