DOCs: improve mass and inertia docs#445
Merged
Gui-FernandesBR merged 15 commits intomasterfrom Nov 12, 2023
Merged
Conversation
Gui-FernandesBR
requested review from
MateusStano,
giovaniceotto and
phmbressan
Gui-FernandesBR
commented
Oct 28, 2023
3 tasks
MateusStano
approved these changes
Nov 7, 2023
Member
MateusStano
left a comment
MateusStano
left a comment
There was a problem hiding this comment.
Really Great! Just made a few suggestions, but otherwise this is ready to merge
Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
Co-authored-by: MateusStano <69485049+MateusStano@users.noreply.github.com>
Member
Author
|
All good now. @phmbressan could you also review this one before merging? This changes much of the motor's documentation, I'd like to have an opinion from you. |
phmbressan
approved these changes
Nov 11, 2023
Collaborator
phmbressan
left a comment
phmbressan
left a comment
There was a problem hiding this comment.
Docs seems much clearer now. Made some small comments that I would rather to not overlook.
Note: when applying a correction, please check it out for other possible instances of the same dosctring. Its is hard to pinpoint all occurences on GitHub comments.
- Refined input parameters for apogee and liftoff speed calculations - Inertia definition in the Rocket class - Change the Motor.dry_mass definition - Avoid repetition of dry_mass definitions - Add a few for docstrings
parameter as in Motor class
Member
Author
|
All good now. Thanks for both reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCurrent behavior
New behavior
Breaking change
Additional information