MNT: adding example docs to the find_closest() function#439
Merged
Gui-FernandesBR merged 1 commit intodevelopfrom Oct 14, 2023
Merged
MNT: adding example docs to the find_closest() function#439Gui-FernandesBR merged 1 commit intodevelopfrom
Gui-FernandesBR merged 1 commit intodevelopfrom
Conversation
phmbressan
approved these changes
Oct 14, 2023
Collaborator
phmbressan
left a comment
phmbressan
left a comment
There was a problem hiding this comment.
Approved, well written doctest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCurrent behavior
There is this function
tools.find_closest()that have been used inside the Flight class. I faced it when working in the last BUG fix #438 . It can be better tested and explained with some examples in its docstring.New behavior
The docstring of the function was modified.
This PR is complementary to the last one, just wanted to put it in here to alleviate last PR.
Breaking change
Additional information
None