BUG: flight.prints.max_values() fails when launching an EmptyMotor#438
Merged
Gui-FernandesBR merged 3 commits intomasterfrom Oct 14, 2023
Merged
BUG: flight.prints.max_values() fails when launching an EmptyMotor#438Gui-FernandesBR merged 3 commits intomasterfrom
Gui-FernandesBR merged 3 commits intomasterfrom
Conversation
- This happens when we use EmptyMotors - ValueError: attempt to get argmax of an empty sequence
giovaniceotto
approved these changes
Oct 13, 2023
Member
giovaniceotto
left a comment
There was a problem hiding this comment.
Great fix @Gui-FernandesBR. Nice touch adding a test to make sure we don't experience this again.
6 tasks
phmbressan
approved these changes
Oct 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCurrent behavior
New behavior
A simple code line solved the problem, and I added a simple test to avoid getting this problem again.
Breaking change
Additional information
Enter text here...