BUG: Maintaing Extrapolation when Adding Discrete Functions with Constants#432
Merged
Gui-FernandesBR merged 3 commits intodevelopfrom Oct 9, 2023
Merged
Conversation
phmbressan
approved these changes
Oct 8, 2023
Member
|
Well done, @MateusStano ! Did you also conder other occurrencies of the same behavior in the same class?
|
Gui-FernandesBR
approved these changes
Oct 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCurrent behavior & New behavior
When adding a constant value to a discrete Function, the extrapolation method is not maintained. This PR fixes this issue