Merged
Conversation
MAINT: Update develop branch from v1.0.0 master
Update develop regarding README contributors
Gui-FernandesBR
approved these changes
Oct 3, 2023
Member
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Overall a simple and effective solution. I really liked it.
As this is a bug solving, I believe we should merge it directly to the master branch so we don't spend much time until actually getting these changes to the default branch.
MateusStano
requested changes
Oct 4, 2023
Member
There was a problem hiding this comment.
I think there are still some things wrong thorought the code. Here is what I found:
rocket_prints.py: Line 97,rocket.py: Line 102, documentation is wrongflight.py:effective_1rlandeffective_2rlseem wrongflight.py:bandcparameters inu_dotflight.py:r_NOZinu_dot_generalizedflight.py: inbparameter ofrotational_energy
Btw. The effective rail cached properties were duplicated, I just deleted them here because they are still related to this bug
MateusStano
approved these changes
Oct 7, 2023
Gui-FernandesBR
approved these changes
Oct 7, 2023
Member
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Approved again, good work here!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCurrent behavior
A bug was identified by @Gui-FernandesBR regarding
add_motorcoordinate conversion. A legacy assumption ofnozzle_position=0was being considered in code.New behavior
The coordinate conversion was fixed and now is consistent with the documentation: positions are defined with respect to the coordinate system's origin of the objects involved.
A parametrized test was added to check this behavior.
Breaking change