Merged
Conversation
Gui-FernandesBR
commented
Sep 25, 2023
Gui-FernandesBR
commented
Sep 25, 2023
Gui-FernandesBR
commented
Sep 25, 2023
phmbressan
reviewed
Sep 26, 2023
Member
Author
|
Have you ever wondered if there is something better than "spectacular"? Great Work!! I've been able to debug some rockets thanks to the new implementations. The only flaw I could find so far is the position of the legend, this is a problem with matplotlib in general. |
Member
Author
Gui-FernandesBR
commented
Oct 7, 2023
Member
Author
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
I would approve if I wasn't the PR's author
MateusStano
approved these changes
Oct 7, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCurrent behavior
We know that sometimes it is hard to check if we have correctly defined the rocket before simulating it.
Also, sometimes we just need to ensure that our rocket looks good on RocketPy.
New behavior
Just added a method to draw the entire rocket. You can already try the
Rocket.draw()method.Here the first example:

Breaking change
Additional information
Some comments on the reviewing process: