Skip incomplete lines in on-type-formatting#615
Merged
renkun-ken merged 4 commits intomasterfrom Apr 24, 2023
Merged
Conversation
randy3k
reviewed
Apr 24, 2023
randy3k
approved these changes
Apr 24, 2023
Member
randy3k
left a comment
randy3k
left a comment
There was a problem hiding this comment.
Just some comments, otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #607
This PR skips incomplete lines in the backward parsing in on-type-formatting so that if the previous line ends with a binary operator or comma (as incomplete, thanks to #613), the parsing will include the line.
The on-type-formatting should work properly with the following case: