bump to 0.3.10 by randy3k · Pull Request #409 · REditorSupport/languageserver

randy3k · 2021-04-03T16:51:22Z

TODO:

update NEWS
final touchup
submit to CRAN

* fix_string_detection: need to reset the string state fix raw string detection

renkun-ken · 2021-04-17T13:16:23Z

I think the new release should include the latest commit then.

randy3k · 2021-04-18T06:18:48Z

Just submitted to CRAN.

randy3k · 2021-04-19T16:47:22Z

@renkun-ken
Just saw another macOS failure at https://github.com/REditorSupport/languageserver/runs/2377902109#step:5:136
Something fishy is going on.

randy3k · 2021-04-19T16:58:44Z

I think I have figured outt the reason. The full path is

source("/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Rtmpe5QjIW/working_dir/Rtmp0hI9cO/file8806c53b4cc.R")

When we do textDocument/definition, somehow it returns the var as in/var/folders.. instead of the whole path.
It might happen when the file has not been probably parsed (yet) and the "find token" mechinisum is dispatched.

This is the detail of the log found in the Artifacts

Details

[2021-04-19 05:52:25.081] session: {
"pid": 4569,
"wd": "/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Rtmp0SQM6a/file611633eb7d3/languageserver.Rcheck/tests/testthat",
"args": ["/Library/Frameworks/R.framework/Resources/bin/exec/R", "--slave", "-e", "languageserver::run(debug~+=+~'/private/tmp/languageserver/macos-log')"],
"env": {
"__CF_USER_TEXT_ENCODING": "0x1F5:0:0",
"R_CHECK_BASHISMS": "TRUE",
"R_CHECK_CODE_USAGE_VIA_NAMESPACES": "TRUE",
"R_CHECK_CODE_USAGE_WITH_ONLY_BASE_ATTACHED": "TRUE",
"R_CHECK_CODOC_VARIABLES_IN_USAGES": "TRUE",
"R_CHECK_COMPILATION_FLAGS": "TRUE",
"R_CHECK_CONNECTIONS_LEFT_OPEN": "TRUE",
"R_CHECK_DATALIST": "TRUE",
"R_CHECK_DEPENDS_ONLY_DATA": "TRUE",
"R_CHECK_DOT_FIRSTLIB": "TRUE",
"R_CHECK_EXCESSIVE_IMPORTS": "20",
"R_CHECK_FUTURE_FILE_TIMESTAMPS": "TRUE",
"R_CHECK_INSTALL_DEPENDS": "TRUE",
"R_CHECK_INTERNALS2": "1",
"R_CHECK_LENGTH_1_CONDITION": "package:R_CHECK_PACKAGE_NAME,verbose",
"R_CHECK_LENGTH_1_LOGIC2": "package:R_CHECK_PACKAGE_NAME,verbose",
"R_CHECK_LICENSE": "TRUE",
"R_CHECK_LIMIT_CORES": "TRUE",
"R_CHECK_NATIVE_ROUTINE_REGISTRATION": "TRUE",
"R_CHECK_NO_RECOMMENDED": "TRUE",
"R_CHECK_NO_STOP_ON_TEST_ERROR": "TRUE",
"R_CHECK_ORPHANED": "TRUE",
"R_CHECK_PACKAGE_DATASETS_SUPPRESS_NOTES": "TRUE",
"R_CHECK_PACKAGE_NAME": "languageserver",
"R_CHECK_PACKAGES_USED_CRAN_INCOMING_NOTES": "TRUE",
"R_CHECK_PACKAGES_USED_IGNORE_UNUSED_IMPORTS": "TRUE",
"R_CHECK_PACKAGES_USED_IN_TESTS_USE_SUBDIRS": "TRUE",
"R_CHECK_PRAGMAS": "TRUE",
"R_CHECK_R_DEPENDS": "warn",
"R_CHECK_R_ON_PATH": "TRUE",
"R_CHECK_RD_CONTENTS_KEYWORDS": "TRUE",
"R_CHECK_S3_METHODS_NOT_REGISTERED": "TRUE",
"R_CHECK_SCREEN_DEVICE": "stop",
"R_CHECK_SHLIB_OPENMP_FLAGS": "TRUE",
"R_CHECK_SIZE_OF_TARBALL": "76996",
"R_CHECK_SYSTEM_CLOCK": "FALSE",
"R_CHECK_TIMINGS": "10",
"R_OPTIONS_STRINGS_AS_FACTORS": "FALSE",
"R_SHLIB_BUILD_OBJECTS_SYMBOL_TABLES": "TRUE",
"AGENT_TOOLSDIRECTORY": "/Users/runner/hostedtoolcache",
"ANDROID_HOME": "/Users/runner/Library/Android/sdk",
"ANDROID_NDK_18R_PATH": "/Users/runner/Library/Android/sdk/ndk/18.1.5063045",
"ANDROID_NDK_HOME": "/Users/runner/Library/Android/sdk/ndk-bundle",
"ANDROID_NDK_LATEST_HOME": "/Users/runner/Library/Android/sdk/ndk/22.1.7171670",
"ANDROID_NDK_ROOT": "/Users/runner/Library/Android/sdk/ndk-bundle",
"ANDROID_SDK_ROOT": "/Users/runner/Library/Android/sdk",
"BIBINPUTS": ".:.:/Library/Frameworks/R.framework/Resources/share/texmf/bibtex/bib::/Library/Frameworks/R.framework/Resources/share/texmf/bibtex/bib:",
"BOOTSTRAP_HASKELL_NONINTERACTIVE": "1",
"BSTINPUTS": ".:.:/Library/Frameworks/R.framework/Resources/share/texmf/bibtex/bst::/Library/Frameworks/R.framework/Resources/share/texmf/bibtex/bst:",
"CALLR_CHILD_R_LIBS": "/Users/runner/work/_temp/Library:/Library/Frameworks/R.framework/Versions/4.0/Resources/library",
"CALLR_CHILD_R_LIBS_SITE": "",
"CALLR_CHILD_R_LIBS_USER": "/Users/runner/work/_temp/Library:/Library/Frameworks/R.framework/Versions/4.0/Resources/library",
"CALLR_R_LIBS_SITE_BAK": "",
"CALLR_R_LIBS_USER_BAK": "/Users/runner/work/_temp/Library",
"CALLR_R_PROFILE_USER_BAK": "/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T//Rtmp0SQM6a/file6112e988d6a",
"CHROMEWEBDRIVER": "/usr/local/Caskroom/chromedriver/89.0.4389.23",
"CI": "true",
"CONDA": "/usr/local/miniconda",
"CYGWIN": "nodosfilewarning",
"DOTNET_MULTILEVEL_LOOKUP": "0",
"DOTNET_ROOT": "/Users/runner/.dotnet",
"DYLD_FALLBACK_LIBRARY_PATH": "/Library/Frameworks/R.framework/Resources/lib:/Users/runner/hostedtoolcache/Java_Adopt_jdk/8.0.282-8/x64/Contents/Home/lib/server",
"EDGEWEBDRIVER": "/usr/local/share/edge_driver",
"EDITOR": "vi",
"GECKOWEBDRIVER": "/usr/local/opt/geckodriver/bin",
"GITHUB_ACTION": "run2",
"GITHUB_ACTION_REF": "",
"GITHUB_ACTION_REPOSITORY": "",
"GITHUB_ACTIONS": "true",
"GITHUB_ACTOR": "randy3k",
"GITHUB_API_URL": "https://api.github.com",
"GITHUB_BASE_REF": "master",
"GITHUB_ENV": "/Users/runner/work/_temp/_runner_file_commands/set_env_7a63375a-b33e-4c27-b9ca-0fcbf6b7ed99",
"GITHUB_EVENT_NAME": "pull_request",
"GITHUB_EVENT_PATH": "/Users/runner/work/_temp/_github_workflow/event.json",
"GITHUB_GRAPHQL_URL": "https://api.github.com/graphql",
"GITHUB_HEAD_REF": "release/0.3.10",
"GITHUB_JOB": "macos",
"GITHUB_PATH": "/Users/runner/work/_temp/_runner_file_commands/add_path_7a63375a-b33e-4c27-b9ca-0fcbf6b7ed99",
"GITHUB_REF": "refs/pull/409/merge",
"GITHUB_REPOSITORY": "REditorSupport/languageserver",
"GITHUB_REPOSITORY_OWNER": "REditorSupport",
"GITHUB_RETENTION_DAYS": "90",
"GITHUB_RUN_ID": "762463588",
"GITHUB_RUN_NUMBER": "1095",
"GITHUB_SERVER_URL": "https://github.com",
"GITHUB_SHA": "c05b77b5201ac9215beaa6ba6bd3e2c650752d9b",
"GITHUB_WORKFLOW": "build",
"GITHUB_WORKSPACE": "/Users/runner/work/languageserver/languageserver",
"HOME": "/Users/runner",
"HOMEBREW_CASK_OPTS": "--no-quarantine",
"HOMEBREW_CLEANUP_PERIODIC_FULL_DAYS": "3650",
"HOMEBREW_NO_AUTO_UPDATE": "1",
"ImageOS": "macos1015",
"ImageVersion": "20210412.2",
"JAVA_HOME": "/Users/runner/hostedtoolcache/Java_Adopt_jdk/8.0.282-8/x64/Contents/Home",
"JAVA_HOME_11_X64": "/Users/runner/hostedtoolcache/Java_Adopt_jdk/11.0.10-9/x64/Contents/Home",
"JAVA_HOME_12_X64": "/Users/runner/hostedtoolcache/Java_Adopt_jdk/12.0.2-10.3/x64/Contents/Home",
"JAVA_HOME_13_X64": "/Users/runner/hostedtoolcache/Java_Adopt_jdk/13.0.2-8.1/x64/Contents/Home",
"JAVA_HOME_14_X64": "/Users/runner/hostedtoolcache/Java_Adopt_jdk/14.0.2-12/x64/Contents/Home",
"JAVA_HOME_8_X64": "/Users/runner/hostedtoolcache/Java_Adopt_jdk/8.0.282-8/x64/Contents/Home",
"LANG": "en_US.UTF-8",
"LANGUAGE": "en",
"LC_ALL": "en_US.UTF-8",
"LC_COLLATE": "C",
"LC_CTYPE": "en_US.UTF-8",
"LN_S": "ln -s",
"LOGNAME": "runner",
"MAKE": "make",
"NOT_CRAN": "true",
"NUNIT_BASE_PATH": "/Library/Developer/nunit",
"NUNIT3_PATH": "/Library/Developer/nunit/3.6.0",
"NVM_CD_FLAGS": "",
"NVM_DIR": "/Users/runner/.nvm",
"PAGER": "/usr/bin/less",
"PATH": "/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Rtmp0SQM6a/file611633eb7d3/languageserver.Rcheck/R_check_bin:/usr/local/gfortran/bin:/usr/local/opt/pipx_bin:/Users/runner/.cargo/bin:/usr/local/lib/ruby/gems/2.7.0/bin:/usr/local/opt/ruby@2.7/bin:/usr/local/opt/curl/bin:/usr/local/bin:/usr/local/sbin:/Users/runner/bin:/Users/runner/.yarn/bin:/Users/runner/Library/Android/sdk/tools:/Users/runner/Library/Android/sdk/platform-tools:/Users/runner/Library/Android/sdk/ndk-bundle:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/usr/bin:/bin:/usr/sbin:/sbin:/Users/runner/.dotnet/tools:/Users/runner/.ghcup/bin:/Users/runner/hostedtoolcache/stack/2.5.1/x64",
"PERFLOG_LOCATION_SETTING": "RUNNER_PERFLOG",
"PIPX_BIN_DIR": "/usr/local/opt/pipx_bin",
"PIPX_HOME": "/usr/local/opt/pipx",
"POWERSHELL_DISTRIBUTION_CHANNEL": "GitHub-Actions-macos1015",
"PROCESSX_PSDFDQRQLYEG_1618810954": "YES",
"PROCESSX_PSZCQEWU3OVU_1618811543": "YES",
"PWD": "/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Rtmp0SQM6a/file611633eb7d3/languageserver.Rcheck/tests/testthat",
"R_ARCH": "",
"R_BATCH": "",
"R_BROWSER": "false",
"R_BZIPCMD": "/usr/bin/bzip2",
"R_CMD": "/Library/Frameworks/R.framework/Resources/bin/Rcmd",
"R_DEFAULT_PACKAGES": "",
"R_DOC_DIR": "/Library/Frameworks/R.framework/Resources/doc",
"R_ENVIRON": "",
"R_ENVIRON_USER": "",
"R_GZIPCMD": "/usr/bin/gzip",
"R_HOME": "/Library/Frameworks/R.framework/Resources",
"R_INCLUDE_DIR": "/Library/Frameworks/R.framework/Resources/include",
"R_LANGSVR_LOG": "/tmp/languageserver/macos-log",
"R_LANGSVR_POOL_SIZE": "1",
"R_LANGSVR_TEST_FAST": "NO",
"R_LIBS": "/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T//Rtmpe5QjIW/RLIBS_63d598ba277",
"R_LIBS_SITE": "no_such_dir",
"R_LIBS_USER": "",
"R_OSTYPE": "unix",
"R_PAPERSIZE": "a4",
"R_PAPERSIZE_USER": "a4",
"R_PDFVIEWER": "false",
"R_PLATFORM": "x86_64-apple-darwin17.0",
"R_PRINTCMD": "lpr",
"R_PROFILE": "",
"R_PROFILE_USER": "",
"R_QPDF": "/Library/Frameworks/R.framework/Resources/bin/qpdf",
"R_RD4PDF": "times,inconsolata,hyper",
"R_SESSION_TMPDIR": "/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T//Rtmpe5QjIW/working_dir/Rtmp7ZArZL",
"R_SHARE_DIR": "/Library/Frameworks/R.framework/Resources/share",
"R_STRIP_SHARED_LIB": "strip -x",
"R_STRIP_STATIC_LIB": "strip -S",
"R_SYSTEM_ABI": "macos,gcc,gxx,gfortran,gfortran",
"R_TESTS": "",
"R_TEXI2DVICMD": "/usr/local/bin/texi2dvi",
"R_UNZIPCMD": "/usr/bin/unzip",
"R_VERSION": "4.0.5",
"R_ZIPCMD": "/usr/bin/zip",
"RCT_NO_LAUNCH_PACKAGER": "1",
"RSTUDIO_CONSOLE_WIDTH": "80",
"RUNNER_OS": "macOS",
"RUNNER_PERFLOG": "/usr/local/opt/runner/perflog",
"RUNNER_TEMP": "/Users/runner/work/_temp",
"RUNNER_TOOL_CACHE": "/Users/runner/hostedtoolcache",
"RUNNER_TRACKING_ID": "github_77aa7d09-f663-4322-8bfa-0c202bb02997",
"RUNNER_WORKSPACE": "/Users/runner/work/languageserver",
"SED": "/usr/bin/sed",
"SHELL": "/bin/bash",
"SHLVL": "6",
"SSH_AUTH_SOCK": "/private/tmp/com.apple.launchd.hINarFBUn7/Listeners",
"TAR": "/usr/bin/tar",
"TESTTHAT": "true",
"TESTTHAT_PKG": "languageserver",
"TEXINPUTS": ".:.:/Library/Frameworks/R.framework/Resources/share/texmf/tex/latex::/Library/Frameworks/R.framework/Resources/share/texmf/tex/latex:",
"TMPDIR": "/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T//Rtmpe5QjIW/working_dir",
"TZ": "UTC",
"USER": "runner",
"VCPKG_INSTALLATION_ROOT": "/usr/local/share/vcpkg",
"XCODE_10_DEVELOPER_DIR": "/Applications/Xcode_10.3.app/Contents/Developer",
"XCODE_11_DEVELOPER_DIR": "/Applications/Xcode_11.7.app/Contents/Developer",
"XCODE_12_DEVELOPER_DIR": "/Applications/Xcode_12.4.app/Contents/Developer",
"XPC_FLAGS": "0x0",
"XPC_SERVICE_NAME": "0"
}
}
[2021-04-19 05:52:25.314] initialization config: {
"rootUri": "file:///var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T//Rtmpe5QjIW/working_dir/Rtmp0hI9cO",
"capabilities": null
}
[2021-04-19 05:52:28.124] deliver: ["Response", "Message", "R6"]
[2021-04-19 05:52:29.500] received: Content-Length: 40
[2021-04-19 05:52:29.533] received payload.
[2021-04-19 05:52:29.535] handling notification: initialized
[2021-04-19 05:52:29.535] on_initialized
[2021-04-19 05:52:29.537] received: Content-Length: 105
[2021-04-19 05:52:29.551] received payload.
[2021-04-19 05:52:29.552] handling notification: workspace/didChangeConfiguration
[2021-04-19 05:52:29.553] settings {
"diagnostics": false
}
[2021-04-19 05:52:29.557] {
"diagnostics": false
}
[2021-04-19 05:52:29.558] disable diagnostics
[2021-04-19 05:52:29.560] received: Content-Length: 237
[2021-04-19 05:52:29.636] received payload.
[2021-04-19 05:52:29.640] handling notification: textDocument/didSave
[2021-04-19 05:52:29.641] did save: {
"uri": "file:///var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Rtmpe5QjIW/working_dir/Rtmp0hI9cO/file8806c53b4cc.R"
}
[2021-04-19 05:52:29.654] parse session acquired session_id = 1 remain pool size = 0
[2021-04-19 05:52:29.657] parse session ready 1 2021-04-19 05:52:29
[2021-04-19 05:52:29.664] received: Content-Length: 342
[2021-04-19 05:52:29.738] received payload.
[2021-04-19 05:52:29.740] handling notification: textDocument/didSave
[2021-04-19 05:52:29.741] did save: {
"uri": "file:///var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Rtmpe5QjIW/working_dir/Rtmp0hI9cO/file8806b82f4a3.R"
}
[2021-04-19 05:52:29.778] received: Content-Length: 239
[2021-04-19 05:52:29.831] received payload.
[2021-04-19 05:52:29.832] handling request: textDocument/definition
[2021-04-19 05:52:29.836] token: {
"full_token": "var",
"right_token": "var",
"package": null,
"accessor": "",
"token": "var"
}
[2021-04-19 05:52:29.838] guess namespace: stats
[2021-04-19 05:52:29.841] deliver: ["Response", "Message", "R6"]
[2021-04-19 05:52:29.851] parse session released session_id = 1 remain pool size = 1
[2021-04-19 05:52:29.852] parse_callback called: {
"uri": "file:///var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Rtmpe5QjIW/working_dir/Rtmp0hI9cO/file8806c53b4cc.R",
"version": null
}
[2021-04-19 05:52:29.855] parse task timing: 0.201704025268555 file:///var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Rtmpe5QjIW/working_dir/Rtmp0hI9cO/file8806c53b4cc.R
[2021-04-19 05:52:30.071] parse session acquired session_id = 1 remain pool size = 0
[2021-04-19 05:52:30.094] received: Content-Length: 239
[2021-04-19 05:52:30.144] received payload.
[2021-04-19 05:52:30.146] handling request: textDocument/definition
[2021-04-19 05:52:30.213] token: {
"full_token": "file8806c53b4cc.R",
"right_token": "ile8806c53b4cc.R",
"package": null,
"accessor": "",
"token": "file8806c53b4cc.R"
}
[2021-04-19 05:52:30.298] deliver: ["Response", "Message", "R6"]
[2021-04-19 05:52:30.330] parse session released session_id = 1 remain pool size = 1
[2021-04-19 05:52:30.334] parse_callback called: {
"uri": "file:///var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Rtmpe5QjIW/working_dir/Rtmp0hI9cO/file8806b82f4a3.R",
"version": null
}
[2021-04-19 05:52:30.359] parse task timing: 0.617522954940796 file:///var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Rtmpe5QjIW/working_dir/Rtmp0hI9cO/file8806b82f4a3.R
[2021-04-19 05:52:30.662] resolve_callback called: {
"uri": "file:///var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Rtmpe5QjIW/working_dir/Rtmp0hI9cO/file8806c53b4cc.R",
"version": null
}
[2021-04-19 05:52:30.664] resolve task timing: 0.809977054595947 file:///var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Rtmpe5QjIW/working_dir/Rtmp0hI9cO/file8806c53b4cc.R

randy3k · 2021-04-19T17:04:40Z

Luckily, the CRAN submission has rejected because of the unnecessary line for LazyData: a88d819
So we would be able to include the fix in the next release.

* master: always check scope for workspace$get_definition

renkun-ken · 2021-04-19T22:29:37Z

This is quite subtle but the cause of error immediately makes good sense! Thanks for digging into this!

randy3k added 2 commits April 3, 2021 09:50

bump to 0.3.10

485bc73

Merge branch 'fix_string_detection' into release/0.3.10

492bff0

* fix_string_detection: need to reset the string state fix raw string detection

randy3k added 4 commits April 17, 2021 09:10

Merge branch 'master' into release/0.3.10

0410e0f

updated README.md

2dc2c87

bump date

8290c9c

use tagbot::changelog()

af68a0c

randy3k added 2 commits April 18, 2021 22:37

fix year

0b63f93

remove LazyData

a88d819

randy3k mentioned this pull request Apr 19, 2021

definition fix #419

Merged

Merge branch 'master' into release/0.3.10

e272fe1

* master: always check scope for workspace$get_definition

randy3k merged commit c2d3545 into master Apr 20, 2021

randy3k deleted the release/0.3.10 branch April 20, 2021 11:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump to 0.3.10#409

bump to 0.3.10#409
randy3k merged 9 commits intomasterfrom
release/0.3.10

randy3k commented Apr 3, 2021 •

edited

Loading

Uh oh!

renkun-ken commented Apr 17, 2021

Uh oh!

randy3k commented Apr 18, 2021

Uh oh!

randy3k commented Apr 19, 2021

Uh oh!

randy3k commented Apr 19, 2021 •

edited

Loading

Uh oh!

randy3k commented Apr 19, 2021 •

edited

Loading

Uh oh!

renkun-ken commented Apr 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

randy3k commented Apr 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

renkun-ken commented Apr 17, 2021

Uh oh!

randy3k commented Apr 18, 2021

Uh oh!

randy3k commented Apr 19, 2021

Uh oh!

randy3k commented Apr 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

randy3k commented Apr 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

renkun-ken commented Apr 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

randy3k commented Apr 3, 2021 •

edited

Loading

randy3k commented Apr 19, 2021 •

edited

Loading

randy3k commented Apr 19, 2021 •

edited

Loading