Improve token completion#372
Merged
renkun-ken merged 4 commits intoREditorSupport:masterfrom Jan 28, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the token completion with the following changes:
(to trigger completion to in accompany with Add initial pipeline completion support vscode-R#530, the current token_completion may produce too many symbols once(triggers completion. This PR makes token_completion only show symbols after$andSYMBOL_SUBsymbols likefooinmutate(foo = bar)when triggertokenis empty (e.g.foo$andfun(), which are the most frequent ways to introduce new data variables.tokenis not empty, then all symbols from the document that start withtokenare searched, which is the original method.This makes it possible to work with the following examples:
where
|is the cursor and the completion should work as expected to complete the tokens from the document.