Fix checking symbol on rhs of assignment expression#342
Merged
renkun-ken merged 2 commits intoREditorSupport:masterfrom Oct 2, 2020
Merged
Fix checking symbol on rhs of assignment expression#342renkun-ken merged 2 commits intoREditorSupport:masterfrom
renkun-ken merged 2 commits intoREditorSupport:masterfrom
Conversation
randy3k
approved these changes
Oct 2, 2020
Member
randy3k
left a comment
randy3k
left a comment
There was a problem hiding this comment.
LGTM. Actually, the XPATH syntax is too complex for me to review 😓
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #341
This PR improves the XPaths of definition and hover so that the XPaths ensure that the requested token is not included in the value expression of the assignment, i.e. RHS of left assignment and equal assignment and LHS of right assignment.
Then the definition and hover providers will regard line 1 as the definition of token
testin line 2 on RHS of the assignment: