X Tutup
Skip to content

Cleanup COM interfaces in jump list code - fix PreserveSig attributes #9899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmenaga merged 2 commits into from
Oct 15, 2019
Merged

Cleanup COM interfaces in jump list code - fix PreserveSig attributes #9899

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07a5dcd
Fix PreserveSig attributes. Remove unnecessary MethodImpl attributes.
weltkante Oct 12, 2019
c478c06
Fix whitespace issue
weltkante Oct 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/Microsoft.PowerShell.ConsoleHost/WindowsTaskbarJumpList/ComInterfaces.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ internal interface IPropertyStore
/// </summary>
/// <param name="propertyCount"></param>
/// <returns></returns>
[MethodImpl(MethodImplOptions.InternalCall, MethodCodeType = MethodCodeType.Runtime)]
[PreserveSig]
HResult GetCount([Out] out uint propertyCount);

/// <summary>
Expand All @@ -115,7 +115,7 @@ internal interface IPropertyStore
/// <param name="propertyIndex"></param>
/// <param name="key"></param>
/// <returns></returns>
[MethodImpl(MethodImplOptions.InternalCall, MethodCodeType = MethodCodeType.Runtime)]
[PreserveSig]
HResult GetAt([In] uint propertyIndex, out PropertyKey key);

/// <summary>
Expand All @@ -124,7 +124,7 @@ internal interface IPropertyStore
/// <param name="key"></param>
/// <param name="pv"></param>
/// <returns></returns>
[MethodImpl(MethodImplOptions.InternalCall, MethodCodeType = MethodCodeType.Runtime)]
[PreserveSig]
HResult GetValue([In] ref PropertyKey key, [Out] PropVariant pv);

/// <summary>
Expand All @@ -133,15 +133,14 @@ internal interface IPropertyStore
/// <param name="key"></param>
/// <param name="pv"></param>
/// <returns></returns>
[MethodImpl(MethodImplOptions.InternalCall, MethodCodeType = MethodCodeType.Runtime), PreserveSig]
[PreserveSig]
HResult SetValue([In] ref PropertyKey key, [In] PropVariant pv);

/// <summary>
/// Commits the changes.
/// </summary>
/// <returns></returns>
[PreserveSig]
[MethodImpl(MethodImplOptions.InternalCall, MethodCodeType = MethodCodeType.Runtime)]
HResult Commit();
}

Expand Down Expand Up @@ -199,9 +198,8 @@ void GetAt(
internal interface IObjectCollection
{
// IObjectArray
[PreserveSig]
void GetCount(out uint cObjects);
[PreserveSig]

void GetAt(
uint iIndex,
ref Guid riid,
Expand Down
X Tutup