X Tutup
Skip to content

WIP - Do Not Review Yet - Try to use STA thread when creating TaskBar JumpList and add temporary logging statements#9896

Closed
bergmeister wants to merge 8 commits intoPowerShell:masterfrom
bergmeister:CatchJumpListExceptionAndAddDebugStatements
Closed

WIP - Do Not Review Yet - Try to use STA thread when creating TaskBar JumpList and add temporary logging statements#9896
bergmeister wants to merge 8 commits intoPowerShell:masterfrom
bergmeister:CatchJumpListExceptionAndAddDebugStatements

Conversation

@bergmeister
Copy link
Contributor

@bergmeister bergmeister commented Jun 14, 2019 •
edited
Loading

PR Summary

This PR is NOT to be reviewed yet and just serves the purpose of giving this build to people to tests (so that they know the build comes from a trusted place).
This is for issue #9295

PR Context

PR Checklist

@bergmeister bergmeister mentioned this pull request Jun 14, 2019
Closed
@bergmeister
Fix Startup.Tests.ps1 expectations to expect System.Security.Cryptogr…
fac06de 
…aphy.Primitives.dll and System.Security.Principal.dll to be only loaded on Windows
@bergmeister
Revert "Fix Startup.Tests.ps1 expectations to expect System.Security.…
9fa1f5e 
…Cryptography.Primitives.dll and System.Security.Principal.dll to be only loaded on Windows"

This reverts commit fac06de.
@daxian-dbw
Copy link
Member

daxian-dbw commented Jun 17, 2019

@bergmeister is this somehow related to #9899 or the issue #9295?

@bergmeister
Copy link
Contributor Author

bergmeister commented Jun 17, 2019 •
edited
Loading

It is related to the second issue: #9295

Instead of giving people a locally built MSI to test build if the catch block can catch the fatal CLR error reported in that issue (and added logging where the error happens), I opened this draft PR so that people can fetch it safely (i.e. so that they know it is built from a trusted place where they see the change of this test build)

@rjmholt rjmholt closed this Jun 17, 2019
@rjmholt rjmholt reopened this Jun 17, 2019
@bergmeister
Copy link
Contributor Author

bergmeister commented Jun 20, 2019 •
edited
Loading

Closing now as we have received feedback in the issue

@bergmeister
Copy link
Contributor Author

bergmeister commented Jul 3, 2019

Re-open with a new experiment using an STA thread because the CoreClr team feedback that the APIs are STA only but netcore did not prohibit this

@bergmeister bergmeister reopened this Jul 3, 2019
@bergmeister bergmeister changed the title WIP - Do Not Review Yet - Try to catch any exception when creating TaskBar JumpList and add temporary logging statements WIP - Do Not Review Yet - Try to use STA thread when creating TaskBar JumpList and add temporary logging statements Jul 3, 2019
@bergmeister
Copy link
Contributor Author

bergmeister commented Jul 16, 2019

Closing now since the fix (in another PR) has been merged into master and released in 6.2.2 (and soon also 7.0.0-preview.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

1 more reviewer

@PoshChan PoshChan PoshChan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bergmeister @daxian-dbw @PoshChan @rjmholt
X Tutup