X Tutup
Skip to content

[release/v7.4] Add ability to capture MSBuild Binary logs when restore fails #24799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 1 commit into from
Jan 16, 2025
Merged

[release/v7.4] Add ability to capture MSBuild Binary logs when restore fails #24799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .pipelines/PowerShell-Coordinated_Packages-Official.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ parameters:
displayName: Enable MSBuild Binary Logs
type: boolean
default: false
- name: ENABLE_MSBUILD_BINLOGS
displayName: Enable MSBuild Binary Logs
type: boolean
default: false

resources:
repositories:
Expand Down
6 changes: 3 additions & 3 deletions build.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,7 @@ function Switch-PSNugetConfig {
} elseif ( $Source -eq 'NuGetOnly') {
New-NugetConfigFile -NugetPackageSource $nugetorg -Destination "$PSScriptRoot/" @extraParams
New-NugetConfigFile -NugetPackageSource $gallery -Destination "$PSScriptRoot/src/Modules/" @extraParams
New-NugetConfigFile -NugetPackageSource $gallery -Destination "$PSScriptRoot/test/tools/Modules/" @extraParams
New-NugetConfigFile -NugetPackageSource $gallery -Destination "$PSScriptRoot/test/tools/Modules/" @extraParams
} elseif ( $Source -eq 'Private') {
$powerShellPackages = [NugetPackageSource] @{Url = 'https://pkgs.dev.azure.com/powershell/PowerShell/_packaging/PowerShell/nuget/v3/index.json'; Name = 'powershell' }

Expand Down Expand Up @@ -882,7 +882,7 @@ function Restore-PSPackage
$RestoreArguments += "--interactive"
}

if ($env:ENABLE_MSBUILD_BINLOGS -eq 'true') {
if ($env:ENABLE_MSBUILD_BINLOGS) {
$RestoreArguments += '-bl'
}

Expand All @@ -903,7 +903,7 @@ function Restore-PSPackage
$retryCount++
if($retryCount -ge $maxTries)
{
if ($env:ENABLE_MSBUILD_BINLOGS -eq 'true') {
if ($env:ENABLE_MSBUILD_BINLOGS) {
if ( Test-Path ./msbuild.binlog ) {
if (!(Test-Path $env:OB_OUTPUTDIRECTORY -PathType Container)) {
$null = New-Item -path $env:OB_OUTPUTDIRECTORY -ItemType Directory -Force -Verbose
Expand Down
Loading
X Tutup