X Tutup
Skip to content

Add a parameter that skips verify packages step#24763

Merged
jshigetomi merged 2 commits intomasterfrom
addsskipverify
Jan 10, 2025
Merged

Add a parameter that skips verify packages step#24763
jshigetomi merged 2 commits intomasterfrom
addsskipverify

Conversation

@jshigetomi
Copy link
Collaborator

@jshigetomi jshigetomi commented Jan 10, 2025

PR Summary

This pull request introduces a new parameter, SkipVerifyPackages, to the pipeline configuration files to allow skipping the verification of package licenses. The changes are primarily focused on the addition of this parameter and the conditional logic to handle it.

Pipeline Configuration Enhancements:

  • Added SkipVerifyPackages parameter to .pipelines/apiscan-gen-notice.yml to control the skipping of package verification.
  • Updated the extends section in .pipelines/apiscan-gen-notice.yml to pass the SkipVerifyPackages parameter to the compliance template.
  • Introduced the SkipVerifyPackages parameter in .pipelines/templates/compliance/generateNotice.yml to be used within the compliance jobs.
  • Added a condition to skip the package verification step in the generateNotice job based on the SkipVerifyPackages parameter.
  • Removed unnecessary blank lines in the generateNotice job script.

PR Context

PR Checklist

@jshigetomi jshigetomi marked this pull request as ready for review January 10, 2025 19:58
@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-CI-macos

@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-CI-linux

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-CI-windows

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-CI-static-analysis

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-Windows-Packinging-CI

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@jshigetomi
Copy link
Collaborator Author

/azp run PSResourceGet ACR

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jshigetomi jshigetomi enabled auto-merge (squash) January 10, 2025 20:05
@jshigetomi jshigetomi merged commit 311674b into master Jan 10, 2025
13 checks passed
@TravisEz13 TravisEz13 deleted the addsskipverify branch January 10, 2025 20:06
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Jan 10, 2025

📣 Hey @jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@TravisEz13 TravisEz13 added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log BackPort-7.4.x-Consider BackPort-7.5.x-Consider BackPort-7.5.x-Approved labels Jan 10, 2025
TravisEz13 pushed a commit that referenced this pull request Jan 15, 2025
* added a parameter that skips verify packages step

* fix parameter string to boolean value

---------

Co-authored-by: Justin Chung <chungjustin@microsoft.com>
TravisEz13 added a commit that referenced this pull request Jan 16, 2025
* added a parameter that skips verify packages step

* fix parameter string to boolean value

---------

Co-authored-by: Justin Chung <124807742+jshigetomi@users.noreply.github.com>
Co-authored-by: Justin Chung <chungjustin@microsoft.com>
TravisEz13 pushed a commit that referenced this pull request Jan 16, 2025
* added a parameter that skips verify packages step

* fix parameter string to boolean value

---------

Co-authored-by: Justin Chung <chungjustin@microsoft.com>
TravisEz13 added a commit that referenced this pull request Jan 16, 2025
* added a parameter that skips verify packages step

* fix parameter string to boolean value

---------

Co-authored-by: Justin Chung <124807742+jshigetomi@users.noreply.github.com>
Co-authored-by: Justin Chung <chungjustin@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BackPort-7.4.x-Done BackPort-7.5.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup